diff options
| author | Minghao Chi <chi.minghao@zte.com.cn> | 2022-05-16 11:22:51 +0300 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2022-05-17 14:04:16 +0300 |
| commit | d1e7f009bfff8b739599c7ff89fb794ef6d4a44d (patch) | |
| tree | 66908879d86aa89f7262da9f111417ec6ffa8afa /drivers/net/ethernet/qlogic | |
| parent | bd81bfb5a1d1aa811ccb370aa5d118d0f87877bc (diff) | |
| download | linux-d1e7f009bfff8b739599c7ff89fb794ef6d4a44d.tar.xz | |
net: qede: Remove unnecessary synchronize_irq() before free_irq()
Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Link: https://lore.kernel.org/r/20220516082251.1651350-1-chi.minghao@zte.com.cn
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/net/ethernet/qlogic')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qede/qede_main.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c index b4e5a15e308b..f56b679adb4b 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_main.c +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c @@ -1916,7 +1916,6 @@ static void qede_sync_free_irqs(struct qede_dev *edev) for (i = 0; i < edev->int_info.used_cnt; i++) { if (edev->int_info.msix_cnt) { - synchronize_irq(edev->int_info.msix[i].vector); free_irq(edev->int_info.msix[i].vector, &edev->fp_array[i]); } else { |