diff options
| author | Wang Xiayang <xywang.sjtu@sjtu.edu.cn> | 2019-07-31 10:31:14 +0300 |
|---|---|---|
| committer | Marc Kleine-Budde <mkl@pengutronix.de> | 2019-08-02 14:26:10 +0300 |
| commit | cd28aa2e056cd1ea79fc5f24eed0ce868c6cab5c (patch) | |
| tree | 6e9f42b8a3ddddf8bb09af65a7580464e54dd2a9 /drivers/net/can/sja1000 | |
| parent | 224c04973db1125fcebefffd86115f99f50f8277 (diff) | |
| download | linux-cd28aa2e056cd1ea79fc5f24eed0ce868c6cab5c.tar.xz | |
can: sja1000: force the string buffer NULL-terminated
strncpy() does not ensure NULL-termination when the input string size
equals to the destination buffer size IFNAMSIZ. The output string
'name' is passed to dev_info which relies on NULL-termination.
Use strlcpy() instead.
This issue is identified by a Coccinelle script.
Signed-off-by: Wang Xiayang <xywang.sjtu@sjtu.edu.cn>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to 'drivers/net/can/sja1000')
| -rw-r--r-- | drivers/net/can/sja1000/peak_pcmcia.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/can/sja1000/peak_pcmcia.c b/drivers/net/can/sja1000/peak_pcmcia.c index 185c7f7d38a4..5e0d5e8101c8 100644 --- a/drivers/net/can/sja1000/peak_pcmcia.c +++ b/drivers/net/can/sja1000/peak_pcmcia.c @@ -479,7 +479,7 @@ static void pcan_free_channels(struct pcan_pccard *card) if (!netdev) continue; - strncpy(name, netdev->name, IFNAMSIZ); + strlcpy(name, netdev->name, IFNAMSIZ); unregister_sja1000dev(netdev); |