diff options
author | Jakub Kicinski <kuba@kernel.org> | 2022-11-09 21:32:54 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2022-11-11 00:52:51 +0300 |
commit | c1b05105573b2cd5845921eb0d2caa26e2144a34 (patch) | |
tree | 77871fdd5fc01a44d76fb6f70ffd75e39a52038c /drivers/net/can/janz-ican3.c | |
parent | 1fb22ed671950bbc0c402034d206fcb334d1fd3a (diff) | |
download | linux-c1b05105573b2cd5845921eb0d2caa26e2144a34.tar.xz |
genetlink: fix single op policy dump when do is present
Jonathan reports crashes when running net-next in Meta's fleet.
Stats collection uses ethtool -I which does a per-op policy dump
to check if stats are supported. We don't initialize the dumpit
information if doit succeeds due to evaluation short-circuiting.
The crash may look like this:
BUG: kernel NULL pointer dereference, address: 0000000000000cc0
RIP: 0010:netlink_policy_dump_add_policy+0x174/0x2a0
ctrl_dumppolicy_start+0x19f/0x2f0
genl_start+0xe7/0x140
Or we may trigger a warning:
WARNING: CPU: 1 PID: 785 at net/netlink/policy.c:87 netlink_policy_dump_get_policy_idx+0x79/0x80
RIP: 0010:netlink_policy_dump_get_policy_idx+0x79/0x80
ctrl_dumppolicy_put_op+0x214/0x360
depending on what garbage we pick up from the stack.
Reported-by: Jonathan Lemon <bsd@meta.com>
Fixes: 26588edbef60 ("genetlink: support split policies in ctrl_dumppolicy_put_op()")
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20221109183254.554051-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/can/janz-ican3.c')
0 files changed, 0 insertions, 0 deletions