diff options
| author | Brian Norris <computersforpeace@gmail.com> | 2015-12-09 21:24:03 +0300 |
|---|---|---|
| committer | Brian Norris <computersforpeace@gmail.com> | 2015-12-10 01:57:44 +0300 |
| commit | adc83bf8896353603213754353dd66dae69e3d7f (patch) | |
| tree | 30c186e19aa8a5f92117cce23c43dc840e19c699 /drivers/mtd/mtdcore.c | |
| parent | 07fd2f871c5e3dfb8ff5eb9c4b44fdb4cf1aeff5 (diff) | |
| download | linux-adc83bf8896353603213754353dd66dae69e3d7f.tar.xz | |
mtd: partitions: support a cleanup callback for parsers
If partition parsers need to clean up their resources, we shouldn't
assume that all memory will fit in a single kmalloc() that the caller
can kfree(). We should allow the parser to provide a proper cleanup
routine.
Note that this means we need to keep a hold on the parser's module for a
bit longer, and release it later with mtd_part_parser_put().
Alongside this, define a default callback that we'll automatically use
if the parser doesn't provide one, so we can still retain the old
behavior.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Diffstat (limited to 'drivers/mtd/mtdcore.c')
| -rw-r--r-- | drivers/mtd/mtdcore.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index 20b2b38247b6..89d811e7b04a 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -630,8 +630,7 @@ int mtd_device_parse_register(struct mtd_info *mtd, const char * const *types, out: /* Cleanup any parsed partitions */ - if (parsed.parser) - kfree(parsed.parts); + mtd_part_parser_cleanup(&parsed); return ret; } EXPORT_SYMBOL_GPL(mtd_device_parse_register); |