summaryrefslogtreecommitdiff
path: root/drivers/mtd/lpddr/Makefile
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2020-05-05 17:01:16 +0300
committerMiquel Raynal <miquel.raynal@bootlin.com>2020-08-27 15:36:07 +0300
commit3e1b6469f8324bee5927b063e2aca30d3e56b907 (patch)
treedee7c74719f1f3710c9838d924fb4fbf6d3b2599 /drivers/mtd/lpddr/Makefile
parent1d0e5ebf0caaaadbc93470850d17786f94c776c2 (diff)
downloadlinux-3e1b6469f8324bee5927b063e2aca30d3e56b907.tar.xz
mtd: lpddr: fix excessive stack usage with clang
Building lpddr2_nvm with clang can result in a giant stack usage in one function: drivers/mtd/lpddr/lpddr2_nvm.c:399:12: error: stack frame size of 1144 bytes in function 'lpddr2_nvm_probe' [-Werror,-Wframe-larger-than=] The problem is that clang decides to build a copy of the mtd_info structure on the stack and then do a memcpy() into the actual version. It shouldn't really do it that way, but it's not strictly a bug either. As a workaround, use a static const version of the structure to assign most of the members upfront and then only set the few members that require runtime knowledge at probe time. Fixes: 96ba9dd65788 ("mtd: lpddr: add driver for LPDDR2-NVM PCM memories") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20200505140136.263461-1-arnd@arndb.de
Diffstat (limited to 'drivers/mtd/lpddr/Makefile')
0 files changed, 0 insertions, 0 deletions