diff options
| author | Bjorn Helgaas <bhelgaas@google.com> | 2023-03-07 23:24:35 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-03-09 19:33:00 +0300 |
| commit | 1a0aae883093f304c4dac441d527a893eb840c5d (patch) | |
| tree | 3699490b65c8f2ec84ad1223a0ae562b67216a43 /drivers/misc/genwqe | |
| parent | 8efc52743ecb5c69d2e4faba965a3e14418c2494 (diff) | |
| download | linux-1a0aae883093f304c4dac441d527a893eb840c5d.tar.xz | |
misc: genwqe: Drop redundant pci_enable_pcie_error_reporting()
pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration, so the
driver doesn't need to do it itself.
Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.
Note that this only controls ERR_* Messages from the device. An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://lore.kernel.org/r/20230307202435.880921-1-helgaas@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/genwqe')
| -rw-r--r-- | drivers/misc/genwqe/card_base.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c index 5b63d179b24e..4829bc2208d6 100644 --- a/drivers/misc/genwqe/card_base.c +++ b/drivers/misc/genwqe/card_base.c @@ -19,7 +19,6 @@ #include <linux/types.h> #include <linux/pci.h> #include <linux/err.h> -#include <linux/aer.h> #include <linux/string.h> #include <linux/sched.h> #include <linux/wait.h> @@ -1099,7 +1098,6 @@ static int genwqe_pci_setup(struct genwqe_dev *cd) } pci_set_master(pci_dev); - pci_enable_pcie_error_reporting(pci_dev); /* EEH recovery requires PCIe fundamental reset */ pci_dev->needs_freset = 1; |