diff options
| author | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-06-10 09:57:02 +0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2021-06-17 10:27:08 +0300 |
| commit | 5368b1ee2939961a16e74972b69088433fc52195 (patch) | |
| tree | 8ee658c149fa552403173c371ea822bf01e3e6c7 /drivers/media/common | |
| parent | 235406dca37ecf6f00e0378e965a3dd37590c389 (diff) | |
| download | linux-5368b1ee2939961a16e74972b69088433fc52195.tar.xz | |
media: siano: fix device register error path
As reported by smatch:
drivers/media/common/siano/smsdvb-main.c:1231 smsdvb_hotplug() warn: '&client->entry' not removed from list
If an error occur at the end of the registration logic, it won't
drop the device from the list.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/media/common')
| -rw-r--r-- | drivers/media/common/siano/smsdvb-main.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/media/common/siano/smsdvb-main.c b/drivers/media/common/siano/smsdvb-main.c index b8a163a47d09..f80caaa333da 100644 --- a/drivers/media/common/siano/smsdvb-main.c +++ b/drivers/media/common/siano/smsdvb-main.c @@ -1212,6 +1212,10 @@ static int smsdvb_hotplug(struct smscore_device_t *coredev, return 0; media_graph_error: + mutex_lock(&g_smsdvb_clientslock); + list_del(&client->entry); + mutex_unlock(&g_smsdvb_clientslock); + smsdvb_debugfs_release(client); client_error: |