summaryrefslogtreecommitdiff
path: root/drivers/macintosh
diff options
context:
space:
mode:
authorVaibhav Jain <vaibhav@linux.ibm.com>2020-09-12 11:14:51 +0300
committerMichael Ellerman <mpe@ellerman.id.au>2020-09-16 15:05:03 +0300
commitca78ef2f08ccfa29b711d644964cdf9d7ace15e5 (patch)
tree4a76baa796b8035d55811c149172eec240ab8a34 /drivers/macintosh
parent8f7e57e8e29c4fc788811dd4db96126272b8df91 (diff)
downloadlinux-ca78ef2f08ccfa29b711d644964cdf9d7ace15e5.tar.xz
powerpc/papr_scm: Fix warning triggered by perf_stats_show()
A warning is reported by the kernel in case perf_stats_show() returns an error code. The warning is of the form below: papr_scm ibm,persistent-memory:ibm,pmemory@44100001: Failed to query performance stats, Err:-10 dev_attr_show: perf_stats_show+0x0/0x1c0 [papr_scm] returned bad count fill_read_buffer: dev_attr_show+0x0/0xb0 returned bad count On investigation it looks like that the compiler is silently truncating the return value of drc_pmem_query_stats() from 'long' to 'int', since the variable used to store the return code 'rc' is an 'int'. This truncated value is then returned back as a 'ssize_t' back from perf_stats_show() to 'dev_attr_show()' which thinks of it as a large unsigned number and triggers this warning.. To fix this we update the type of variable 'rc' from 'int' to 'ssize_t' that prevents the compiler from truncating the return value of drc_pmem_query_stats() and returning correct signed value back from perf_stats_show(). Fixes: 2d02bf835e57 ("powerpc/papr_scm: Fetch nvdimm performance stats from PHYP") Signed-off-by: Vaibhav Jain <vaibhav@linux.ibm.com> Reviewed-by: Ira Weiny <ira.weiny@intel.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20200912081451.66225-1-vaibhav@linux.ibm.com
Diffstat (limited to 'drivers/macintosh')
0 files changed, 0 insertions, 0 deletions