diff options
| author | Antonio Ospite <ospite@studenti.unina.it> | 2013-08-02 22:23:01 +0400 |
|---|---|---|
| committer | Bryan Wu <cooloney@gmail.com> | 2013-08-27 04:22:11 +0400 |
| commit | 29ab311c44fd9de932bceddc6b2587600abd1c49 (patch) | |
| tree | 2f5b29bd61e40e498171056cb19ee86030977831 /drivers/leds | |
| parent | 2e87c09209cce10a0744eb28c25e93fe9fdc3e81 (diff) | |
| download | linux-29ab311c44fd9de932bceddc6b2587600abd1c49.tar.xz | |
leds: leds-lp3944, fix "sparse" warning "mixing different enum types"
Fix a warning from "sparse":
drivers/leds/leds-lp3944.c:292:23: warning: mixing different enum types
drivers/leds/leds-lp3944.c:292:23: int enum led_brightness versus
drivers/leds/leds-lp3944.c:292:23: int enum lp3944_status
Keeping track of LP3944_LED_STATUS_OFF and LP3944_LED_STATUS_ON only in
lp3944_led_set_brightness() is OK, as the handling of DIM (blinking)
mode[s] is in lp3944_led_set_blink().
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
Diffstat (limited to 'drivers/leds')
| -rw-r--r-- | drivers/leds/leds-lp3944.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/leds/leds-lp3944.c b/drivers/leds/leds-lp3944.c index 2b53d10e5607..8e1abdcd4c9d 100644 --- a/drivers/leds/leds-lp3944.c +++ b/drivers/leds/leds-lp3944.c @@ -289,7 +289,7 @@ static void lp3944_led_set_brightness(struct led_classdev *led_cdev, dev_dbg(&led->client->dev, "%s: %s, %d\n", __func__, led_cdev->name, brightness); - led->status = brightness; + led->status = !!brightness; schedule_work(&led->work); } |