diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-06-01 11:09:30 +0300 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2022-06-09 19:36:57 +0300 |
| commit | eff4780f83d0ae3e5b6c02ff5d999dc4c1c5c8ce (patch) | |
| tree | f9ab977e6627c11d0909d3fcd1f2999d9c82a501 /drivers/irqchip/irq-realtek-rtl.c | |
| parent | fa1ad9d4cc47ca2470cd904ad4519f05d7e43a2b (diff) | |
| download | linux-eff4780f83d0ae3e5b6c02ff5d999dc4c1c5c8ce.tar.xz | |
irqchip/realtek-rtl: Fix refcount leak in map_interrupts
of_find_node_by_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
This function doesn't call of_node_put() in error path.
Call of_node_put() directly after of_property_read_u32() to cover
both normal path and error path.
Fixes: 9f3a0f34b84a ("irqchip: Add support for Realtek RTL838x/RTL839x interrupt controller")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-7-linmq006@gmail.com
Diffstat (limited to 'drivers/irqchip/irq-realtek-rtl.c')
| -rw-r--r-- | drivers/irqchip/irq-realtek-rtl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-realtek-rtl.c b/drivers/irqchip/irq-realtek-rtl.c index 50a56820c99b..56bf502d9c67 100644 --- a/drivers/irqchip/irq-realtek-rtl.c +++ b/drivers/irqchip/irq-realtek-rtl.c @@ -134,9 +134,9 @@ static int __init map_interrupts(struct device_node *node, struct irq_domain *do if (!cpu_ictl) return -EINVAL; ret = of_property_read_u32(cpu_ictl, "#interrupt-cells", &tmp); + of_node_put(cpu_ictl); if (ret || tmp != 1) return -EINVAL; - of_node_put(cpu_ictl); cpu_int = be32_to_cpup(imap + 2); if (cpu_int > 7 || cpu_int < 2) |