diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2013-01-21 17:02:58 +0400 |
|---|---|---|
| committer | Roland Dreier <roland@purestorage.com> | 2013-02-16 03:23:26 +0400 |
| commit | 6950a235b86cf4e73d2b8e5476e7d0eb8f61af63 (patch) | |
| tree | 5388c52e93d1c3be64d64ff9666536b31c10211f /drivers/infiniband/hw/mlx4/sysfs.c | |
| parent | cab66d1273e6490603cf5256155584d38cecca68 (diff) | |
| download | linux-6950a235b86cf4e73d2b8e5476e7d0eb8f61af63.tar.xz | |
IB/mlx4: Adjust duplicate test
Delete successive tests to the same location. The code tested the result
of a previous allocation, that itself was already tested. It is changed to
test the result of the most recent allocation.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@s exists@
local idexpression y;
expression x,e;
@@
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\)
when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\)
*if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
{ ... when forall
return ...; }
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Roland Dreier <roland@purestorage.com>
Diffstat (limited to 'drivers/infiniband/hw/mlx4/sysfs.c')
| -rw-r--r-- | drivers/infiniband/hw/mlx4/sysfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/mlx4/sysfs.c b/drivers/infiniband/hw/mlx4/sysfs.c index 5b2a01dfb907..97516eb363b7 100644 --- a/drivers/infiniband/hw/mlx4/sysfs.c +++ b/drivers/infiniband/hw/mlx4/sysfs.c @@ -732,7 +732,7 @@ int mlx4_ib_device_register_sysfs(struct mlx4_ib_dev *dev) dev->ports_parent = kobject_create_and_add("ports", kobject_get(dev->iov_parent)); - if (!dev->iov_parent) { + if (!dev->ports_parent) { ret = -ENOMEM; goto err_ports; } |