diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-08-19 23:48:08 +0300 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2021-10-29 23:04:35 +0300 |
| commit | 7f98960c046ee1136e7096aee168eda03aef8a5d (patch) | |
| tree | d86be86bbf1e6857060cc65d13460e02b301e2a0 /drivers/i2c/busses/i2c-xlr.c | |
| parent | 5fe058b04d017a91cd1fa9281c57d0c3d3a34f58 (diff) | |
| download | linux-7f98960c046ee1136e7096aee168eda03aef8a5d.tar.xz | |
i2c: xlr: Fix a resource leak in the error handling path of 'xlr_i2c_probe()'
A successful 'clk_prepare()' call should be balanced by a corresponding
'clk_unprepare()' call in the error handling path of the probe, as already
done in the remove function.
More specifically, 'clk_prepare_enable()' is used, but 'clk_disable()' is
also already called. So just the unprepare step has still to be done.
Update the error handling path accordingly.
Fixes: 75d31c2372e4 ("i2c: xlr: add support for Sigma Designs controller variant")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c/busses/i2c-xlr.c')
| -rw-r--r-- | drivers/i2c/busses/i2c-xlr.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-xlr.c b/drivers/i2c/busses/i2c-xlr.c index 126d1393e548..9ce20652d494 100644 --- a/drivers/i2c/busses/i2c-xlr.c +++ b/drivers/i2c/busses/i2c-xlr.c @@ -431,11 +431,15 @@ static int xlr_i2c_probe(struct platform_device *pdev) i2c_set_adapdata(&priv->adap, priv); ret = i2c_add_numbered_adapter(&priv->adap); if (ret < 0) - return ret; + goto err_unprepare_clk; platform_set_drvdata(pdev, priv); dev_info(&priv->adap.dev, "Added I2C Bus.\n"); return 0; + +err_unprepare_clk: + clk_unprepare(clk); + return ret; } static int xlr_i2c_remove(struct platform_device *pdev) |