diff options
author | Qinglang Miao <miaoqinglang@huawei.com> | 2020-12-01 12:31:43 +0300 |
---|---|---|
committer | Wolfram Sang <wsa@kernel.org> | 2021-04-14 10:49:17 +0300 |
commit | 780f629741257ed6c54bd3eb53b57f648eabf200 (patch) | |
tree | 0c0e4cdb4c950503daa98eda858e8a2032604ddb /drivers/i2c/busses/i2c-sprd.c | |
parent | 47ff617217ca6a13194fcb35c6c3a0c57c080693 (diff) | |
download | linux-780f629741257ed6c54bd3eb53b57f648eabf200.tar.xz |
i2c: omap: fix reference leak when pm_runtime_get_sync fails
The PM reference count is not expected to be incremented on
return in omap_i2c_probe() and omap_i2c_remove().
However, pm_runtime_get_sync will increment the PM reference
count even failed. Forgetting to putting operation will result
in a reference leak here. I Replace it with pm_runtime_resume_and_get
to keep usage counter balanced.
What's more, error path 'err_free_mem' seems not like a proper
name any more. So I change the name to err_disable_pm and move
pm_runtime_disable below, for pm_runtime of 'pdev->dev' should
be disabled when pm_runtime_resume_and_get fails.
Fixes: 3b0fb97c8dc4 ("I2C: OMAP: Handle error check for pm runtime")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers/i2c/busses/i2c-sprd.c')
0 files changed, 0 insertions, 0 deletions