diff options
| author | Jonathan Cormier <jcormier@criticallink.com> | 2023-01-27 01:32:25 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-03-10 11:33:20 +0300 |
| commit | 355d109fb6b74791ca85403fad9b4d2ff6c588af (patch) | |
| tree | 47724bbe2d9974664c61d6ca0bd142faea975234 /drivers/hwmon | |
| parent | c710243ed668d24e6be8bf2fe2f53339bd6342d8 (diff) | |
| download | linux-355d109fb6b74791ca85403fad9b4d2ff6c588af.tar.xz | |
hwmon: (ltc2945) Handle error case in ltc2945_value_store
[ Upstream commit 178b01eccfb0b8149682f61388400bd3d903dddc ]
ltc2945_val_to_reg errors were not being handled
which would have resulted in register being set to
0 (clamped) instead of being left alone.
Fixes: 6700ce035f83 ("hwmon: Driver for Linear Technologies LTC2945")
Signed-off-by: Jonathan Cormier <jcormier@criticallink.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/ltc2945.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/hwmon/ltc2945.c b/drivers/hwmon/ltc2945.c index 9adebb59f604..c06ab7317431 100644 --- a/drivers/hwmon/ltc2945.c +++ b/drivers/hwmon/ltc2945.c @@ -248,6 +248,8 @@ static ssize_t ltc2945_value_store(struct device *dev, /* convert to register value, then clamp and write result */ regval = ltc2945_val_to_reg(dev, reg, val); + if (regval < 0) + return regval; if (is_power_reg(reg)) { regval = clamp_val(regval, 0, 0xffffff); regbuf[0] = regval >> 16; |