diff options
| author | Nicolin Chen <nicoleotsuka@gmail.com> | 2018-09-30 00:44:05 +0300 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2018-10-11 06:37:13 +0300 |
| commit | c20217b30d675bb8ce3f55768c3cff629641a868 (patch) | |
| tree | fb38ec9cc6286668409906bc6c786a4e0617a31b /drivers/hwmon/ina3221.c | |
| parent | cbc2a23803193f6cbc415bf79f3ec162f3cfc52a (diff) | |
| download | linux-c20217b30d675bb8ce3f55768c3cff629641a868.tar.xz | |
hwmon: (ina3221) Add INA3221_CONFIG to volatile_table
The MSB (15th bit) of INA3221_CONFIG is a self-clear reset bit.
So this register should be added to the volatile_table of the
regmap_config. Otherwise, we will see this bit is sticky in the
regcache which might accidentally reset the chip when an actual
write happens to the register.
This might not be a severe bug for the current code line since
there's no second place touching the INA3221_CONFIG except the
reset routine in the probe().
Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/ina3221.c')
| -rw-r--r-- | drivers/hwmon/ina3221.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c index e6b49500c52a..cfe65ff01051 100644 --- a/drivers/hwmon/ina3221.c +++ b/drivers/hwmon/ina3221.c @@ -353,7 +353,7 @@ static struct attribute *ina3221_attrs[] = { ATTRIBUTE_GROUPS(ina3221); static const struct regmap_range ina3221_yes_ranges[] = { - regmap_reg_range(INA3221_SHUNT1, INA3221_BUS3), + regmap_reg_range(INA3221_CONFIG, INA3221_BUS3), regmap_reg_range(INA3221_MASK_ENABLE, INA3221_MASK_ENABLE), }; |