summaryrefslogtreecommitdiff
path: root/drivers/hwmon/abituguru.c
diff options
context:
space:
mode:
authorJean Delvare <khali@linux-fr.org>2011-05-25 22:43:33 +0400
committerJean Delvare <khali@endymion.delvare>2011-05-25 22:43:33 +0400
commitec693fe5287e1791f4d206e81ebdfdc7d1f8f6b9 (patch)
tree6f261c6f8a23fdd604f6a7b2f31cac906b0533ea /drivers/hwmon/abituguru.c
parent5b0380c94a2e888b7858fbec6fc3ac623bc9b05a (diff)
downloadlinux-ec693fe5287e1791f4d206e81ebdfdc7d1f8f6b9.tar.xz
hwmon: (abituguru) Depend on DMI
The abituguru drivers are only built on X86, where DMI support is now enabled by default. So let these drivers depend on DMI, for the following gains: * Robustness and safety. Detection of these devices is weak and uses non-standard methods, it should really be limited to Abit boards unless the user explicitly asks otherwise. * Code simplicity. The code is easier to read without ifdefs. * Better build testing coverage. Now there's only one way to build the drivers, so no risk of build failure on exotic systems. Signed-off-by: Jean Delvare <khali@linux-fr.org> Acked-by: Guenter Roeck <guenter.roeck@ericsson.com> Acked-by: Alistair John Strachan <alistair@devzero.co.uk> Acked-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/hwmon/abituguru.c')
-rw-r--r--drivers/hwmon/abituguru.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/hwmon/abituguru.c b/drivers/hwmon/abituguru.c
index e7d4c4687f02..65a35cf5b3c5 100644
--- a/drivers/hwmon/abituguru.c
+++ b/drivers/hwmon/abituguru.c
@@ -1448,15 +1448,12 @@ static int __init abituguru_init(void)
{
int address, err;
struct resource res = { .flags = IORESOURCE_IO };
-
-#ifdef CONFIG_DMI
const char *board_vendor = dmi_get_system_info(DMI_BOARD_VENDOR);
/* safety check, refuse to load on non Abit motherboards */
if (!force && (!board_vendor ||
strcmp(board_vendor, "http://www.abit.com.tw/")))
return -ENODEV;
-#endif
address = abituguru_detect();
if (address < 0)