diff options
| author | Michael Kelley <mikelley@microsoft.com> | 2019-11-14 09:32:01 +0300 |
|---|---|---|
| committer | Sasha Levin <sashal@kernel.org> | 2019-11-22 04:10:46 +0300 |
| commit | 7a1323b5dfe44a9013a2cc56ef2973034a00bf88 (patch) | |
| tree | 2878fe886a0cbb5f3fdb2840a11d5acdc73f3523 /drivers/hv | |
| parent | 8aea7f82153d6f292add3eb4bd7ba8edcae5c7f7 (diff) | |
| download | linux-7a1323b5dfe44a9013a2cc56ef2973034a00bf88.tar.xz | |
Drivers: hv: vmbus: Fix crash handler reset of Hyper-V synic
The crash handler calls hv_synic_cleanup() to shutdown the
Hyper-V synthetic interrupt controller. But if the CPU
that calls hv_synic_cleanup() has a VMbus channel interrupt
assigned to it (which is likely the case in smaller VM sizes),
hv_synic_cleanup() returns an error and the synthetic
interrupt controller isn't shutdown. While the lack of
being shutdown hasn't caused a known problem, it still
should be fixed for highest reliability.
So directly call hv_synic_disable_regs() instead of
hv_synic_cleanup(), which ensures that the synic is always
shutdown.
Signed-off-by: Michael Kelley <mikelley@microsoft.com>
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers/hv')
| -rw-r--r-- | drivers/hv/vmbus_drv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c index 845d2a9423ea..f3d0bddc80a7 100644 --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c @@ -2310,7 +2310,7 @@ static void hv_crash_handler(struct pt_regs *regs) vmbus_connection.conn_state = DISCONNECTED; cpu = smp_processor_id(); hv_stimer_cleanup(cpu); - hv_synic_cleanup(cpu); + hv_synic_disable_regs(cpu); hyperv_cleanup(); }; |