diff options
| author | Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com> | 2020-04-16 09:23:35 +0300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2020-04-23 09:17:16 +0300 |
| commit | 2e45676a4d33af47259fa186ea039122ce263ba9 (patch) | |
| tree | 8bba529dc1a9fe11ed8d4760e3a75e421092678f /drivers/dma/pch_dma.c | |
| parent | aee45dba3ad9c87affa95e50747fbb82ff4b2e20 (diff) | |
| download | linux-2e45676a4d33af47259fa186ea039122ce263ba9.tar.xz | |
dmaengine: pch_dma.c: Avoid data race between probe and irq handler
pd->dma.dev is read in irq handler pd_irq().
However, it is set to pdev->dev after request_irq().
Therefore, set pd->dma.dev to pdev->dev before request_irq() to
avoid data race between pch_dma_probe() and pd_irq().
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Link: https://lore.kernel.org/r/20200416062335.29223-1-madhuparnabhowmik10@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/pch_dma.c')
| -rw-r--r-- | drivers/dma/pch_dma.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c index 581e7a290d98..a3b0b4c56a19 100644 --- a/drivers/dma/pch_dma.c +++ b/drivers/dma/pch_dma.c @@ -865,6 +865,7 @@ static int pch_dma_probe(struct pci_dev *pdev, } pci_set_master(pdev); + pd->dma.dev = &pdev->dev; err = request_irq(pdev->irq, pd_irq, IRQF_SHARED, DRV_NAME, pd); if (err) { @@ -880,7 +881,6 @@ static int pch_dma_probe(struct pci_dev *pdev, goto err_free_irq; } - pd->dma.dev = &pdev->dev; INIT_LIST_HEAD(&pd->dma.channels); |