diff options
| author | Satendra Singh Thakur <sst2005@gmail.com> | 2019-11-09 14:35:23 +0300 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2019-11-14 09:46:53 +0300 |
| commit | 1ff95243257fad07290dcbc5f7a6ad79d6e703e2 (patch) | |
| tree | ea78ab1fd1321e6d70047c4b0c75b16435e697e4 /drivers/dma/mediatek | |
| parent | 051f5175f226118ca220b93b87e07e515e727bcb (diff) | |
| download | linux-1ff95243257fad07290dcbc5f7a6ad79d6e703e2.tar.xz | |
dmaengine: mediatek: hsdma_probe: fixed a memory leak when devm_request_irq fails
When devm_request_irq fails, currently, the function
dma_async_device_unregister gets called. This doesn't free
the resources allocated by of_dma_controller_register.
Therefore, we have called of_dma_controller_free for this purpose.
Signed-off-by: Satendra Singh Thakur <sst2005@gmail.com>
Link: https://lore.kernel.org/r/20191109113523.6067-1-sst2005@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/mediatek')
| -rw-r--r-- | drivers/dma/mediatek/mtk-hsdma.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/dma/mediatek/mtk-hsdma.c b/drivers/dma/mediatek/mtk-hsdma.c index 1a2028e1c29e..4c58da742143 100644 --- a/drivers/dma/mediatek/mtk-hsdma.c +++ b/drivers/dma/mediatek/mtk-hsdma.c @@ -997,7 +997,7 @@ static int mtk_hsdma_probe(struct platform_device *pdev) if (err) { dev_err(&pdev->dev, "request_irq failed with err %d\n", err); - goto err_unregister; + goto err_free; } platform_set_drvdata(pdev, hsdma); @@ -1006,6 +1006,8 @@ static int mtk_hsdma_probe(struct platform_device *pdev) return 0; +err_free: + of_dma_controller_free(pdev->dev.of_node); err_unregister: dma_async_device_unregister(dd); |