diff options
author | Viresh Kumar <viresh.kumar@linaro.org> | 2013-01-12 09:14:40 +0400 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2013-02-02 03:01:14 +0400 |
commit | 6954ca9c8b5cbaf45c3e45a5a5a7450c6b55ab27 (patch) | |
tree | a888e21ecf2e7d72b778826f39c71a96dcc9bfa7 /drivers/cpufreq/freq_table.c | |
parent | f6a7409cab3b525c5e55540e7cd08d23e198352f (diff) | |
download | linux-6954ca9c8b5cbaf45c3e45a5a5a7450c6b55ab27.tar.xz |
cpufreq: Don't use cpu removed during cpufreq_driver_unregister
This is how the core works:
cpufreq_driver_unregister()
- subsys_interface_unregister()
- for_each_cpu() call cpufreq_remove_dev(), i.e. 0,1,2,3,4 when we
unregister.
cpufreq_remove_dev():
- Remove policy node
- Call cpufreq_add_dev() for next cpu, sharing mask with removed cpu.
i.e. When cpu 0 is removed, we call it for cpu 1. And when called for cpu 2,
we call it for cpu 3.
- cpufreq_add_dev() would call cpufreq_driver->init()
- init would return mask as AND of 2, 3 and 4 for cluster A7.
- cpufreq core would do online_cpu && policy->cpus
Here is the BUG(). Because cpu hasn't died but we have just unregistered
the cpufreq driver, online cpu would still have cpu 2 in it. And so thing
go bad again.
Solution: Keep cpumask of cpus that are registered with cpufreq core and clear
cpus when we get a call from subsys_interface_unregister() via
cpufreq_remove_dev().
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/cpufreq/freq_table.c')
0 files changed, 0 insertions, 0 deletions