summaryrefslogtreecommitdiff
path: root/drivers/char
diff options
context:
space:
mode:
authorVasily Averin <vvs@virtuozzo.com>2020-06-13 17:18:33 +0300
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>2020-07-02 17:49:00 +0300
commitccf6fb858e17a8f8a914a1c6444d277cfedfeae6 (patch)
treea9f693aa1d58d7b254ca882f0251a45d4d3a58ed /drivers/char
parenteac9347d932b96c09f089ac0673ebe588983e59b (diff)
downloadlinux-ccf6fb858e17a8f8a914a1c6444d277cfedfeae6.tar.xz
tpm_tis: extra chip->ops check on error path in tpm_tis_core_init
Found by smatch: drivers/char/tpm/tpm_tis_core.c:1088 tpm_tis_core_init() warn: variable dereferenced before check 'chip->ops' (see line 979) 'chip->ops' is assigned in the beginning of function in tpmm_chip_alloc->tpm_chip_alloc and is used before first possible goto to error path. Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/tpm/tpm_tis_core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index 2435216bd10a..65ab1b027949 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/drivers/char/tpm/tpm_tis_core.c
@@ -1085,7 +1085,7 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq,
return 0;
out_err:
- if ((chip->ops != NULL) && (chip->ops->clk_enable != NULL))
+ if (chip->ops->clk_enable != NULL)
chip->ops->clk_enable(chip, false);
tpm_tis_remove(chip);