diff options
| author | Jiri Kosina <jkosina@suse.cz> | 2007-02-12 11:52:35 +0300 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-02-12 20:48:30 +0300 |
| commit | efc47135e4b6f7e7d81332f50ef68e4a42819d20 (patch) | |
| tree | eea400d6bbdf846b972dbe7da042a8b641877f59 /drivers/char/ds1302.c | |
| parent | 2869b23e4b95cbafffcd2fe110d77aff8c218405 (diff) | |
| download | linux-efc47135e4b6f7e7d81332f50ef68e4a42819d20.tar.xz | |
[PATCH] DS1302: local_irq_disable() is redundant after local_irq_save()
drivers/char/ds1302.c::get_rtc_time() contains local_irq_disable() call
after local_irq_save(). This looks redundant.
drivers/char/ds1302.c::rtc_ioctl() contains local_irq_disable() call after
local_irq_save(). This looks redundant.
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char/ds1302.c')
| -rw-r--r-- | drivers/char/ds1302.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/char/ds1302.c b/drivers/char/ds1302.c index bcdb107aa967..fada6ddefbae 100644 --- a/drivers/char/ds1302.c +++ b/drivers/char/ds1302.c @@ -120,7 +120,6 @@ get_rtc_time(struct rtc_time *rtc_tm) unsigned long flags; local_irq_save(flags); - local_irq_disable(); rtc_tm->tm_sec = CMOS_READ(RTC_SECONDS); rtc_tm->tm_min = CMOS_READ(RTC_MINUTES); @@ -219,7 +218,6 @@ rtc_ioctl(struct inode *inode, struct file *file, unsigned int cmd, BIN_TO_BCD(yrs); local_irq_save(flags); - local_irq_disable(); CMOS_WRITE(yrs, RTC_YEAR); CMOS_WRITE(mon, RTC_MONTH); CMOS_WRITE(day, RTC_DAY_OF_MONTH); |