diff options
author | Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> | 2019-02-09 02:38:45 +0300 |
---|---|---|
committer | Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> | 2019-02-15 21:48:39 +0300 |
commit | 69ef9bc54715fb1cb7786ada15774e469e822209 (patch) | |
tree | 175415062a9d821fd89f3966a55e19431fa6e14c /drivers/auxdisplay/hd44780.c | |
parent | 8834f5600cf3c8db365e18a3d5cac2c2780c81e5 (diff) | |
download | linux-69ef9bc54715fb1cb7786ada15774e469e822209.tar.xz |
auxdisplay: ht16k33: fix potential user-after-free on module unload
On module unload/remove, we need to ensure that work does not run
after we have freed resources. Concretely, cancel_delayed_work()
may return while the callback function is still running.
From kernel/workqueue.c:
The work callback function may still be running on return,
unless it returns true and the work doesn't re-arm itself.
Explicitly flush or use cancel_delayed_work_sync() to wait on it.
Link: https://lore.kernel.org/lkml/20190204220952.30761-1-TheSven73@googlemail.com/
Reported-by: Sven Van Asbroeck <thesven73@gmail.com>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Sven Van Asbroeck <TheSven73@gmail.com>
Acked-by: Robin van der Gracht <robin@protonic.nl>
Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Diffstat (limited to 'drivers/auxdisplay/hd44780.c')
0 files changed, 0 insertions, 0 deletions