diff options
author | Meng Tang <tangmeng@uniontech.com> | 2022-03-15 10:48:51 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2022-03-17 05:17:49 +0300 |
commit | a8df216630fedadc4e8cc086f0e2e612f9c3d1f4 (patch) | |
tree | 1c1f4320f9044fb7bcd3b3cfa863bcde8461b924 /crypto/rsa_helper.c | |
parent | e077ed58c243afc197bc2a2ba0e1ff61135e4ec2 (diff) | |
download | linux-a8df216630fedadc4e8cc086f0e2e612f9c3d1f4.tar.xz |
hamradio: Fix wrong assignment of 'bbc->cfg.loopback'
In file hamradio/baycom_epp.c, the baycom_setmode interface, there
is a problem with improper use of strstr.
Suppose that when modestr="noloopback", both conditions which are
'strstr(modestr,"noloopback")' and 'strstr(modestr,"loopback")'
will be true(not NULL), this lead the bc->cfg.loopback variable
will be first assigned to 0, and then reassigned to 1.
This will cause 'bc->cfg.loopback = 0' will never take effect. That
obviously violates the logic of the code, so adjust the order of
their execution to solve the problem.
Signed-off-by: Meng Tang <tangmeng@uniontech.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220315074851.6456-1-tangmeng@uniontech.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'crypto/rsa_helper.c')
0 files changed, 0 insertions, 0 deletions