summaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorBrian Foster <bfoster@redhat.com>2017-08-29 20:08:39 +0300
committerDarrick J. Wong <darrick.wong@oracle.com>2017-09-01 20:55:30 +0300
commit99c794c639a65cc7b74f30a674048fd100fe9ac8 (patch)
tree341e2260e5d2e37b89bd6a510b1e9cab818c2967 /block
parent8dc518dfa7dbd079581269e51074b3c55a65a880 (diff)
downloadlinux-99c794c639a65cc7b74f30a674048fd100fe9ac8.tar.xz
xfs: skip bmbt block ino validation during owner change
Extent swap uses xfs_btree_visit_blocks() to fix up bmbt block owners on v5 (!rmapbt) filesystems. The bmbt scan uses xfs_btree_lookup_get_block() to read bmbt blocks which verifies the current owner of the block against the parent inode of the bmbt. This works during extent swap because the bmbt owners are updated to the opposite inode number before the inode extent forks are swapped. The modified bmbt blocks are marked as ordered buffers which allows everything to commit in a single transaction. If the transaction commits to the log and the system crashes such that recovery of the extent swap is required, log recovery restarts the bmbt scan to fix up any bmbt blocks that may have not been written back before the crash. The log recovery bmbt scan occurs after the inode forks have been swapped, however. This causes the bmbt block owner verification to fail, leads to log recovery failure and requires xfs_repair to zap the log to recover. Define a new invalid inode owner flag to inform the btree block lookup mechanism that the current inode may be invalid with respect to the current owner of the bmbt block. Set this flag on the cursor used for change owner scans to allow this operation to work at runtime and during log recovery. Signed-off-by: Brian Foster <bfoster@redhat.com> Fixes: bb3be7e7c ("xfs: check for bogus values in btree block headers") Cc: stable@vger.kernel.org Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions