diff options
author | Damien Le Moal <damien.lemoal@wdc.com> | 2018-02-28 20:35:29 +0300 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2018-03-01 18:39:24 +0300 |
commit | f3bc78d2d4b489590540ab2788d5376583e28173 (patch) | |
tree | 0a6dd46bd1feef14581a7fd0ddc7d704a54c4952 /block/blk-core.c | |
parent | 468f098734ab095b72d8af26bcd4bcb2ed31a3be (diff) | |
download | linux-f3bc78d2d4b489590540ab2788d5376583e28173.tar.xz |
mq-deadline: Make sure to always unlock zones
In case of a failed write request (all retries failed) and when using
libata, the SCSI error handler calls scsi_finish_command(). In the
case of blk-mq this means that scsi_mq_done() does not get called,
that blk_mq_complete_request() does not get called and also that the
mq-deadline .completed_request() method is not called. This results in
the target zone of the failed write request being left in a locked
state, preventing that any new write requests are issued to the same
zone.
Fix this by replacing the .completed_request() method with the
.finish_request() method as this method is always called whether or
not a request completes successfully. Since the .finish_request()
method is only called by the blk-mq core if a .prepare_request()
method exists, add a dummy .prepare_request() method.
Fixes: 5700f69178e9 ("mq-deadline: Introduce zone locking support")
Cc: Hannes Reinecke <hare@suse.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
[ bvanassche: edited patch description ]
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-core.c')
0 files changed, 0 insertions, 0 deletions