summaryrefslogtreecommitdiff
path: root/arch/x86/kvm/irq_comm.c
diff options
context:
space:
mode:
authorRadim Krčmář <rkrcmar@redhat.com>2015-10-08 21:30:00 +0300
committerPaolo Bonzini <pbonzini@redhat.com>2015-10-14 17:41:08 +0300
commit13db77347db175a68edd58a79963cdf5cb3a9607 (patch)
treea3541835b34f7e1a5593eee1af2391b4eb7e1b19 /arch/x86/kvm/irq_comm.c
parentdb2bdcbbbd32e5500b822d5e74ef8b5bd777e687 (diff)
downloadlinux-13db77347db175a68edd58a79963cdf5cb3a9607.tar.xz
KVM: x86: don't notify userspace IOAPIC on edge EOI
On real hardware, edge-triggered interrupts don't set a bit in TMR, which means that IOAPIC isn't notified on EOI. Do the same here. Staying in guest/kernel mode after edge EOI is what we want for most devices. If some bugs could be nicely worked around with edge EOI notifications, we should invest in a better interface. Signed-off-by: Radim Krčmář <rkrcmar@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'arch/x86/kvm/irq_comm.c')
-rw-r--r--arch/x86/kvm/irq_comm.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/arch/x86/kvm/irq_comm.c b/arch/x86/kvm/irq_comm.c
index c89228980230..8f4499c7ffc1 100644
--- a/arch/x86/kvm/irq_comm.c
+++ b/arch/x86/kvm/irq_comm.c
@@ -389,13 +389,15 @@ void kvm_scan_ioapic_routes(struct kvm_vcpu *vcpu, u64 *eoi_exit_bitmap)
for (i = 0; i < nr_ioapic_pins; ++i) {
hlist_for_each_entry(entry, &table->map[i], link) {
u32 dest_id, dest_mode;
+ bool level;
if (entry->type != KVM_IRQ_ROUTING_MSI)
continue;
dest_id = (entry->msi.address_lo >> 12) & 0xff;
dest_mode = (entry->msi.address_lo >> 2) & 0x1;
- if (kvm_apic_match_dest(vcpu, NULL, 0, dest_id,
- dest_mode)) {
+ level = entry->msi.data & MSI_DATA_TRIGGER_LEVEL;
+ if (level && kvm_apic_match_dest(vcpu, NULL, 0,
+ dest_id, dest_mode)) {
u32 vector = entry->msi.data & 0xff;
__set_bit(vector,