diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-11-18 14:11:00 +0300 |
|---|---|---|
| committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2016-12-12 11:01:10 +0300 |
| commit | 9e6e7c74315095fd40f41003850690c711e44420 (patch) | |
| tree | f1c2d08206255394d53b81e7a91720f7db03e501 /arch/s390 | |
| parent | e32eae10e589ec54679c19ca6c9d1b276e9b97cd (diff) | |
| download | linux-9e6e7c74315095fd40f41003850690c711e44420.tar.xz | |
s390/crypto: unlock on error in prng_tdes_read()
We added some new locking but forgot to unlock on error.
Fixes: 57127645d79d ("s390/zcrypt: Introduce new SHA-512 based Pseudo Random Generator.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'arch/s390')
| -rw-r--r-- | arch/s390/crypto/prng.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/arch/s390/crypto/prng.c b/arch/s390/crypto/prng.c index 9cc050f9536c..1113389d0a39 100644 --- a/arch/s390/crypto/prng.c +++ b/arch/s390/crypto/prng.c @@ -507,8 +507,10 @@ static ssize_t prng_tdes_read(struct file *file, char __user *ubuf, prng_data->prngws.byte_counter += n; prng_data->prngws.reseed_counter += n; - if (copy_to_user(ubuf, prng_data->buf, chunk)) - return -EFAULT; + if (copy_to_user(ubuf, prng_data->buf, chunk)) { + ret = -EFAULT; + break; + } nbytes -= chunk; ret += chunk; |