diff options
author | John David Anglin <dave.anglin@bell.net> | 2016-12-07 05:47:04 +0300 |
---|---|---|
committer | Helge Deller <deller@gmx.de> | 2016-12-07 10:56:40 +0300 |
commit | c78e710c1c9fbeff43dddc0aa3d0ff458e70b0cc (patch) | |
tree | 981210b6bafc21ba73f0ea3b2f5ac00f8b60a6b9 /arch/parisc/kernel/pacache.S | |
parent | bc3913a5378cd0ddefd1dfec6917cc12eb23a946 (diff) | |
download | linux-c78e710c1c9fbeff43dddc0aa3d0ff458e70b0cc.tar.xz |
parisc: Purge TLB before setting PTE
The attached change interchanges the order of purging the TLB and
setting the corresponding page table entry. TLB purges are strongly
ordered. It occurred to me one night that setting the PTE first might
have subtle ordering issues on SMP machines and cause random memory
corruption.
A TLB lock guards the insertion of user TLB entries. So after the TLB
is purged, a new entry can't be inserted until the lock is released.
This ensures that the new PTE value is used when the lock is released.
Since making this change, no random segmentation faults have been
observed on the Debian hppa buildd servers.
Signed-off-by: John David Anglin <dave.anglin@bell.net>
Cc: <stable@vger.kernel.org> # v3.16+
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'arch/parisc/kernel/pacache.S')
0 files changed, 0 insertions, 0 deletions