diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2016-08-19 04:16:49 +0300 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2016-09-14 00:49:39 +0300 |
| commit | f35c1e0671728d1c9abc405d05ef548b5fcb2fc4 (patch) | |
| tree | 6237bc7d599269b60e8051675eb7c583189555e9 /arch/hexagon | |
| parent | 3b8767a8f00cc6538ba6b1cf0f88502e2fd2eb90 (diff) | |
| download | linux-f35c1e0671728d1c9abc405d05ef548b5fcb2fc4.tar.xz | |
hexagon: fix strncpy_from_user() error return
It's -EFAULT, not -1 (and contrary to the comment in there,
__strnlen_user() can return 0 - on faults).
Cc: stable@vger.kernel.org
Acked-by: Richard Kuo <rkuo@codeaurora.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'arch/hexagon')
| -rw-r--r-- | arch/hexagon/include/asm/uaccess.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/hexagon/include/asm/uaccess.h b/arch/hexagon/include/asm/uaccess.h index f000a382bc7f..f61cfb28e9f2 100644 --- a/arch/hexagon/include/asm/uaccess.h +++ b/arch/hexagon/include/asm/uaccess.h @@ -103,7 +103,8 @@ static inline long hexagon_strncpy_from_user(char *dst, const char __user *src, { long res = __strnlen_user(src, n); - /* return from strnlen can't be zero -- that would be rubbish. */ + if (unlikely(!res)) + return -EFAULT; if (res > n) { copy_from_user(dst, src, n); |