diff options
| author | David S. Miller <davem@davemloft.net> | 2018-02-26 21:41:47 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-02-26 21:41:47 +0300 |
| commit | 13a55372b64e00e564a08d785ca87bd9d454ba30 (patch) | |
| tree | da513bc5fc70d1c9cff3bda089fc8305b4b4667b /arch/arm/mach-orion5x/Kconfig | |
| parent | 44e524cf8a8c0a8dc3d8256006d57b1d7d59c407 (diff) | |
| download | linux-13a55372b64e00e564a08d785ca87bd9d454ba30.tar.xz | |
ARM: orion5x: Revert commit 4904dbda41c8.
It is not valid for orion5x to use mac_pton().
First of all, the orion5x buffer is not NULL terminated. mac_pton()
has no business operating on non-NULL terminated buffers because
only the caller can know that this is valid and in what manner it
is ok to parse this NULL'less buffer.
Second of all, orion5x operates on an __iomem pointer, which cannot
be dereferenced using normal C pointer operations. Accesses to
such areas much be performed with the proper iomem accessors.
Fixes: 4904dbda41c8 ("ARM: orion5x: use mac_pton() helper")
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/arm/mach-orion5x/Kconfig')
| -rw-r--r-- | arch/arm/mach-orion5x/Kconfig | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/arch/arm/mach-orion5x/Kconfig b/arch/arm/mach-orion5x/Kconfig index 2a7bb6ccdcb7..a810f4dd34b1 100644 --- a/arch/arm/mach-orion5x/Kconfig +++ b/arch/arm/mach-orion5x/Kconfig @@ -58,7 +58,6 @@ config MACH_KUROBOX_PRO config MACH_DNS323 bool "D-Link DNS-323" - select GENERIC_NET_UTILS select I2C_BOARDINFO if I2C help Say 'Y' here if you want your kernel to support the @@ -66,7 +65,6 @@ config MACH_DNS323 config MACH_TS209 bool "QNAP TS-109/TS-209" - select GENERIC_NET_UTILS help Say 'Y' here if you want your kernel to support the QNAP TS-109/TS-209 platform. @@ -101,7 +99,6 @@ config MACH_LINKSTATION_LS_HGL config MACH_TS409 bool "QNAP TS-409" - select GENERIC_NET_UTILS help Say 'Y' here if you want your kernel to support the QNAP TS-409 platform. |