diff options
author | Nathan Chancellor <nathan@kernel.org> | 2021-12-24 01:21:41 +0300 |
---|---|---|
committer | Arnd Bergmann <arnd@arndb.de> | 2022-04-04 17:31:40 +0300 |
commit | 83a1cde5c74bfb44b49cb2a940d044bb2380f4ea (patch) | |
tree | 255be2f6fbd836019df4d6e2d79fcbc8b6f7d5b9 /arch/arm/mach-iop32x | |
parent | 3123109284176b1532874591f7c81f3837bbdc17 (diff) | |
download | linux-83a1cde5c74bfb44b49cb2a940d044bb2380f4ea.tar.xz |
ARM: davinci: da850-evm: Avoid NULL pointer dereference
With newer versions of GCC, there is a panic in da850_evm_config_emac()
when booting multi_v5_defconfig in QEMU under the palmetto-bmc machine:
Unable to handle kernel NULL pointer dereference at virtual address 00000020
pgd = (ptrval)
[00000020] *pgd=00000000
Internal error: Oops: 5 [#1] PREEMPT ARM
Modules linked in:
CPU: 0 PID: 1 Comm: swapper Not tainted 5.15.0 #1
Hardware name: Generic DT based system
PC is at da850_evm_config_emac+0x1c/0x120
LR is at do_one_initcall+0x50/0x1e0
The emac_pdata pointer in soc_info is NULL because davinci_soc_info only
gets populated on davinci machines but da850_evm_config_emac() is called
on all machines via device_initcall().
Move the rmii_en assignment below the machine check so that it is only
dereferenced when running on a supported SoC.
Fixes: bae105879f2f ("davinci: DA850/OMAP-L138 EVM: implement autodetect of RMII PHY")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/YcS4xVWs6bQlQSPC@archlinux-ax161/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Diffstat (limited to 'arch/arm/mach-iop32x')
0 files changed, 0 insertions, 0 deletions