diff options
| author | Geert Uytterhoeven <geert+renesas@glider.be> | 2021-12-03 16:35:06 +0300 |
|---|---|---|
| committer | Rob Herring <robh@kernel.org> | 2021-12-06 23:16:59 +0300 |
| commit | c4cb38b54b365edafb351e5371b9ae9eebf8e805 (patch) | |
| tree | 3937ef4c0d3c51e31f616a0f497e0e1343d9c4ed /Documentation | |
| parent | 96db48c9d777a73a33b1d516c5cfed7a417a5f40 (diff) | |
| download | linux-c4cb38b54b365edafb351e5371b9ae9eebf8e805.tar.xz | |
dt-bindings: input: gpio-keys: Fix interrupts in example
The "interrupts" property in the example looks weird:
- The type is not in the last cell,
- Level interrupts don't work well with gpio-keys, as they keep the
interrupt asserted as long as the key is pressed, causing an
interrupt storm.
Use a more realistic falling-edge interrupt instead.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/47ecd2d8efcf09f8ab47de87a7bcfafc82208776.1638538079.git.geert+renesas@glider.be
Signed-off-by: Rob Herring <robh@kernel.org>
Diffstat (limited to 'Documentation')
| -rw-r--r-- | Documentation/devicetree/bindings/input/gpio-keys.yaml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml index 060a309ff8e7..dbe7ecc19ccb 100644 --- a/Documentation/devicetree/bindings/input/gpio-keys.yaml +++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml @@ -142,7 +142,7 @@ examples: down { label = "GPIO Key DOWN"; linux,code = <108>; - interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; }; }; |