diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2022-04-27 14:49:56 +0300 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2022-04-27 17:25:24 +0300 |
| commit | c5f2b8e9a9f891f67c58a3d9c6bca1eb8449dda2 (patch) | |
| tree | b043cf28e97e437cbf22434d9cdd2f399af1d0e8 /Documentation/networking/tcp-thin.rst | |
| parent | d2833762f23a62cce1636452108706541a735290 (diff) | |
| download | linux-c5f2b8e9a9f891f67c58a3d9c6bca1eb8449dda2.tar.xz | |
platform/x86: asus-wmi: Fix driver not binding when fan curve control probe fails
Before this commit fan_curve_check_present() was trying to not cause
the probe to fail on devices without fan curve control by testing for
known error codes returned by asus_wmi_evaluate_method_buf().
Checking for ENODATA or ENODEV, with the latter being returned by this
function when an ACPI integer with a value of ASUS_WMI_UNSUPPORTED_METHOD
is returned. But for other ACPI integer returns this function just returns
them as is, including the ASUS_WMI_DSTS_UNKNOWN_BIT value of 2.
On the Asus U36SD ASUS_WMI_DSTS_UNKNOWN_BIT gets returned, leading to:
asus-nb-wmi: probe of asus-nb-wmi failed with error 2
Instead of playing whack a mole with error codes here, simply treat all
errors as there not being any fan curves, fixing the driver no longer
loading on the Asus U36SD laptop.
Fixes: e3d13da7f77d ("platform/x86: asus-wmi: Fix regression when probing for fan curve control")
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=2079125
Cc: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20220427114956.332919-1-hdegoede@redhat.com
Diffstat (limited to 'Documentation/networking/tcp-thin.rst')
0 files changed, 0 insertions, 0 deletions