summaryrefslogtreecommitdiff
path: root/Documentation/gpu/drm-internals.rst
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2020-03-23 17:49:01 +0300
committerDaniel Vetter <daniel.vetter@ffwll.ch>2020-03-26 16:48:44 +0300
commit0ce542f7317117a02d65183e047a09911fa08afe (patch)
treee5e71e4e968d88b9e2c96e0901c67a4422d04203 /Documentation/gpu/drm-internals.rst
parentfd7cb5753ef49964ea9db5121c3fc9a4ec21ed8e (diff)
downloadlinux-0ce542f7317117a02d65183e047a09911fa08afe.tar.xz
drm/i915: Don't clear drvdata in ->release
For two reasons: - The driver core clears this already for us after we're unloaded in __device_release_driver(). - It's way too late, the drm_device ->release callback might massively outlive the underlying physical device, since a drm_device can be kept alive by open drm_file or well really anything else userspace is still hanging onto. So if we clear this ourselves, we should clear it in the pci ->remove callback, not in the drm_device ->release callback. Looking at git history this was fixed in the driver core with commit 0998d0631001288a5974afc0b2a5f568bcdecb4d Author: Hans de Goede <hdegoede@redhat.com> Date: Wed May 23 00:09:34 2012 +0200 device-core: Ensure drvdata = NULL when no driver is bound v2: Cite the core fix in the commit message (Chris). v3: Fix commit message and unused variable warning (Jani). Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Jani Nikula <jani.nikula@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200323144950.3018436-3-daniel.vetter@ffwll.ch
Diffstat (limited to 'Documentation/gpu/drm-internals.rst')
0 files changed, 0 insertions, 0 deletions