diff options
| author | Eric Biggers <ebiggers@kernel.org> | 2025-06-20 23:50:27 +0300 |
|---|---|---|
| committer | Eric Biggers <ebiggers@kernel.org> | 2025-06-30 19:31:57 +0300 |
| commit | a98e0d69d544ec6b1510940c901867b4ecd8ba1d (patch) | |
| tree | eff5113d16631ee6b7ee123549f36b01473f7c1a | |
| parent | 8c7c675155ce3f0f6b12c57a47298a390661652d (diff) | |
| download | linux-a98e0d69d544ec6b1510940c901867b4ecd8ba1d.tar.xz | |
nvmem: layouts: Switch from crc32() to crc32_le()
u_boot_env_parse() calls crc32() from within a scope that has a uint32_t
variable named crc32. This works only because crc32() is actually a
macro that expands to crc32_le(). I'm planning to make it an inline
function instead, which will make the usual C scoping rules apply to it.
Therefore, update u_boot_env_parse() to be compatible with that. To do
so, just call crc32_le() directly instead of using the crc32() alias.
(An alternative would be to rename the local variable.)
Acked-by: Srinivas Kandagatla <srini@kernel.org>
Link: https://lore.kernel.org/r/20250620205027.23403-1-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@kernel.org>
| -rw-r--r-- | drivers/nvmem/layouts/u-boot-env.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvmem/layouts/u-boot-env.c b/drivers/nvmem/layouts/u-boot-env.c index 436426d4e8f9..274e8a456e8c 100644 --- a/drivers/nvmem/layouts/u-boot-env.c +++ b/drivers/nvmem/layouts/u-boot-env.c @@ -148,7 +148,7 @@ int u_boot_env_parse(struct device *dev, struct nvmem_device *nvmem, crc32_data_len = dev_size - crc32_data_offset; data_len = dev_size - data_offset; - calc = crc32(~0, buf + crc32_data_offset, crc32_data_len) ^ ~0L; + calc = crc32_le(~0, buf + crc32_data_offset, crc32_data_len) ^ ~0L; if (calc != crc32) { dev_err(dev, "Invalid calculated CRC32: 0x%08x (expected: 0x%08x)\n", calc, crc32); err = -EINVAL; |