summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMiaoqian Lin <linmq006@gmail.com>2022-06-01 11:09:27 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-06-22 15:28:04 +0300
commit6c0010d1dc67c89bcc857c46f542efe318f84ddc (patch)
tree93465f521784e2f357d7eb8db46a3ecf94f7806d
parent2dc14cebe5dc053434b507bb24e6821cb795050f (diff)
downloadlinux-6c0010d1dc67c89bcc857c46f542efe318f84ddc.tar.xz
irqchip/apple-aic: Fix refcount leak in aic_of_ic_init
[ Upstream commit 3d45670fab3c25a7452721e4588cc95c51cda134 ] of_get_child_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: a5e8801202b3 ("irqchip/apple-aic: Parse FIQ affinities from device-tree") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Signed-off-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20220601080930.31005-4-linmq006@gmail.com Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--drivers/irqchip/irq-apple-aic.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index 478d0af16d9f..5ac83185ff47 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -1144,6 +1144,7 @@ static int __init aic_of_ic_init(struct device_node *node, struct device_node *p
for_each_child_of_node(affs, chld)
build_fiq_affinity(irqc, chld);
}
+ of_node_put(affs);
set_handle_irq(aic_handle_irq);
set_handle_fiq(aic_handle_fiq);