diff options
| author | Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> | 2012-03-30 00:58:17 +0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-03-30 01:06:43 +0400 |
| commit | 10bdfb5ef7e1a429a3de31e498942a8ae5749a46 (patch) | |
| tree | 2bda472ac8825a0616ca8632fdc5623f4f8bb0fe | |
| parent | 8da00edc1069f01c34510fa405dc15d96c090a3f (diff) | |
| download | linux-10bdfb5ef7e1a429a3de31e498942a8ae5749a46.tar.xz | |
pagemap: remove remaining unneeded spin_lock()
Commit 025c5b2451e4 ("thp: optimize away unnecessary page table
locking") moves spin_lock() into pmd_trans_huge_lock() in order to avoid
locking unless pmd is for thp. So this spin_lock() is a bug.
Reported-by: Sasha Levin <levinsasha928@gmail.com>
Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | fs/proc/task_mmu.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index c283832d411d..2b9a7607cbd5 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -783,7 +783,6 @@ static int pagemap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, /* find the first VMA at or above 'addr' */ vma = find_vma(walk->mm, addr); - spin_lock(&walk->mm->page_table_lock); if (pmd_trans_huge_lock(pmd, vma) == 1) { for (; addr != end; addr += PAGE_SIZE) { unsigned long offset; |