summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChengguang Xu <cgxu519@gmx.com>2018-06-13 07:05:13 +0300
committerAl Viro <viro@zeniv.linux.org.uk>2018-10-18 09:04:59 +0300
commit515f1867addaba49c1c6ac73abfaffbc192c1db4 (patch)
treefbddee5d65ec3b1156b6e0343bfb4d164593b71f
parent55338ac2a9839557516b00661e6a05daf996fda0 (diff)
downloadlinux-515f1867addaba49c1c6ac73abfaffbc192c1db4.tar.xz
fs/exofs: fix potential memory leak in mount option parsing
There are some cases can cause memory leak when parsing option 'osdname'. Signed-off-by: Chengguang Xu <cgxu519@gmx.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r--fs/exofs/super.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/exofs/super.c b/fs/exofs/super.c
index 41cf2fbee50d..7d61e3fa378c 100644
--- a/fs/exofs/super.c
+++ b/fs/exofs/super.c
@@ -101,6 +101,7 @@ static int parse_options(char *options, struct exofs_mountopt *opts)
token = match_token(p, tokens, args);
switch (token) {
case Opt_name:
+ kfree(opts->dev_name);
opts->dev_name = match_strdup(&args[0]);
if (unlikely(!opts->dev_name)) {
EXOFS_ERR("Error allocating dev_name");
@@ -866,8 +867,10 @@ static struct dentry *exofs_mount(struct file_system_type *type,
int ret;
ret = parse_options(data, &opts);
- if (ret)
+ if (ret) {
+ kfree(opts.dev_name);
return ERR_PTR(ret);
+ }
if (!opts.dev_name)
opts.dev_name = dev_name;