diff options
| author | Julia Lawall <julia@diku.dk> | 2011-04-23 00:46:21 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-04-30 01:17:45 +0400 |
| commit | df43daaae926c3710eda911ec048808c904572fe (patch) | |
| tree | 02c6eabf1a21bbbd91ed0dda7f94a67b2f096034 | |
| parent | 83c67571b372c4a40023a84e183fdb7fa4e89e48 (diff) | |
| download | linux-df43daaae926c3710eda911ec048808c904572fe.tar.xz | |
drivers/tty/moxa.c: Put correct tty value
The tty value that should be put is the one that was just gotten by
tty_port_tty_get, not the one that is the argument to the enclosing
function.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@exists@
local idexpression struct tty_struct *x;
expression ra,rr;
statement S1,S2;
@@
x = tty_port_tty_get(...)
... when != x = rr
when any
when != tty_kref_put(x,...)
when != if (...) { ... tty_kref_put(x,...) ...}
(
if(<+...x...+>) S1 else S2
|
if(...) { ... when != x = ra
when forall
when != tty_kref_put(x,...)
*return...;
}
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/tty/moxa.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c index 6255561dd2a3..ba679ce0a774 100644 --- a/drivers/tty/moxa.c +++ b/drivers/tty/moxa.c @@ -371,7 +371,7 @@ static int moxa_ioctl(struct tty_struct *tty, tmp.cflag = p->cflag; else tmp.cflag = ttyp->termios->c_cflag; - tty_kref_put(tty); + tty_kref_put(ttyp); copy: if (copy_to_user(argm, &tmp, sizeof(tmp))) return -EFAULT; |