diff options
| author | Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com> | 2014-08-05 20:19:37 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-09-09 01:38:14 +0400 |
| commit | 3f0d97d97f2b539cf9ac746be4ec097259e6a8d0 (patch) | |
| tree | abdaa471dee67507343ac4f4586306003e5e4e0c | |
| parent | 69e273c0b0a3c337a521d083374c918dc52c666f (diff) | |
| download | linux-3f0d97d97f2b539cf9ac746be4ec097259e6a8d0.tar.xz | |
Lattice ECP3 FPGA: Check firmware pointer
This patch corrects a lack of testing.
If fw is NULL when calling firmware_load(), it results in a kernel oops.
Signed-off-by: Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/misc/lattice-ecp3-config.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/misc/lattice-ecp3-config.c b/drivers/misc/lattice-ecp3-config.c index 7ffdb589841e..7e1efd5f58f0 100644 --- a/drivers/misc/lattice-ecp3-config.c +++ b/drivers/misc/lattice-ecp3-config.c @@ -79,6 +79,11 @@ static void firmware_load(const struct firmware *fw, void *context) u32 jedec_id; u32 status; + if (fw == NULL) { + dev_err(&spi->dev, "Cannot load firmware, aborting\n"); + return; + } + if (fw->size == 0) { dev_err(&spi->dev, "Error: Firmware size is 0!\n"); return; |