diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2016-11-24 14:05:44 +0300 |
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2016-11-29 19:39:44 +0300 |
| commit | 24c790fbf5d8f54c8c82979db11edea8855b74bf (patch) | |
| tree | d58e5ebbc9a61f500f4b796035a6c18afd8f16d5 | |
| parent | 62280cf2e8bb46d14b47b198720ab2d69b43faf7 (diff) | |
| download | linux-24c790fbf5d8f54c8c82979db11edea8855b74bf.tar.xz | |
iommu/amd: Missing error code in amd_iommu_init_device()
We should set "ret" to -EINVAL if iommu_group_get() fails.
Fixes: 55c99a4dc50f ("iommu/amd: Use iommu_attach_group()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
| -rw-r--r-- | drivers/iommu/amd_iommu_v2.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c index 594849a3a9be..f8ed8c95b685 100644 --- a/drivers/iommu/amd_iommu_v2.c +++ b/drivers/iommu/amd_iommu_v2.c @@ -805,8 +805,10 @@ int amd_iommu_init_device(struct pci_dev *pdev, int pasids) goto out_free_domain; group = iommu_group_get(&pdev->dev); - if (!group) + if (!group) { + ret = -EINVAL; goto out_free_domain; + } ret = iommu_attach_group(dev_state->domain, group); if (ret != 0) |