summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOleksij Rempel <o.rempel@pengutronix.de>2020-11-27 15:36:21 +0300
committerJakub Kicinski <kuba@kernel.org>2020-11-28 04:26:20 +0300
commitfff4c74690018c4f741d1ae68c2ba2143b66844a (patch)
tree67d3ab09bcbfe3cd10b671d2126715ad0b5af184
parent35c58418898b5e80eaa55f5ce861734302c6f157 (diff)
downloadlinux-fff4c74690018c4f741d1ae68c2ba2143b66844a.tar.xz
net: phy: micrel: fix interrupt handling
After migration to the shared interrupt support, the KSZ8031 PHY with enabled interrupt support was not able to notify about link status change. Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback") Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Link: https://lore.kernel.org/r/20201127123621.31234-1-o.rempel@pengutronix.de Signed-off-by: Jakub Kicinski <kuba@kernel.org>
-rw-r--r--drivers/net/phy/micrel.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 97f08f20630b..54e0d75203da 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -207,7 +207,7 @@ static irqreturn_t kszphy_handle_interrupt(struct phy_device *phydev)
return IRQ_NONE;
}
- if ((irq_status & KSZPHY_INTCS_STATUS))
+ if (!(irq_status & KSZPHY_INTCS_STATUS))
return IRQ_NONE;
phy_trigger_machine(phydev);