diff options
| author | Jesper Juhl <jj@chaosbits.net> | 2011-06-20 16:13:10 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-06-22 03:03:17 +0400 |
| commit | dec17b74516bb780de75b41e7cfa0072df16bb82 (patch) | |
| tree | 7f4aff0fb0f3f95dcbb20c9f2afe68dfeaf36fea | |
| parent | 3b182d7d4287f38711f70d58d68cf2a34e582992 (diff) | |
| download | linux-dec17b74516bb780de75b41e7cfa0072df16bb82.tar.xz | |
Remove redundant linux/version.h includes from net/
It was suggested by "make versioncheck" that the follwing includes of
linux/version.h are redundant:
/home/jj/src/linux-2.6/net/caif/caif_dev.c: 14 linux/version.h not needed.
/home/jj/src/linux-2.6/net/caif/chnl_net.c: 10 linux/version.h not needed.
/home/jj/src/linux-2.6/net/ipv4/gre.c: 19 linux/version.h not needed.
/home/jj/src/linux-2.6/net/netfilter/ipset/ip_set_core.c: 20 linux/version.h not needed.
/home/jj/src/linux-2.6/net/netfilter/xt_set.c: 16 linux/version.h not needed.
and it seems that it is right.
Beyond manually inspecting the source files I also did a few build
tests with various configs to confirm that including the header in
those files is indeed not needed.
Here's a patch to remove the pointless includes.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/caif/caif_dev.c | 1 | ||||
| -rw-r--r-- | net/caif/chnl_net.c | 1 | ||||
| -rw-r--r-- | net/ipv4/gre.c | 1 | ||||
| -rw-r--r-- | net/netfilter/ipset/ip_set_core.c | 1 | ||||
| -rw-r--r-- | net/netfilter/xt_set.c | 1 |
5 files changed, 0 insertions, 5 deletions
diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c index 682c0fedf360..7c2fa0a08148 100644 --- a/net/caif/caif_dev.c +++ b/net/caif/caif_dev.c @@ -11,7 +11,6 @@ #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__ -#include <linux/version.h> #include <linux/kernel.h> #include <linux/if_arp.h> #include <linux/net.h> diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c index c628a57953c9..865690948bbc 100644 --- a/net/caif/chnl_net.c +++ b/net/caif/chnl_net.c @@ -7,7 +7,6 @@ #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__ -#include <linux/version.h> #include <linux/fs.h> #include <linux/hardirq.h> #include <linux/init.h> diff --git a/net/ipv4/gre.c b/net/ipv4/gre.c index c6933f2ea310..9dbe10875fbd 100644 --- a/net/ipv4/gre.c +++ b/net/ipv4/gre.c @@ -16,7 +16,6 @@ #include <linux/skbuff.h> #include <linux/in.h> #include <linux/netdevice.h> -#include <linux/version.h> #include <linux/spinlock.h> #include <net/protocol.h> #include <net/gre.h> diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index c012985a5a26..d7e86ef9d23a 100644 --- a/net/netfilter/ipset/ip_set_core.c +++ b/net/netfilter/ipset/ip_set_core.c @@ -17,7 +17,6 @@ #include <linux/spinlock.h> #include <linux/netlink.h> #include <linux/rculist.h> -#include <linux/version.h> #include <net/netlink.h> #include <linux/netfilter.h> diff --git a/net/netfilter/xt_set.c b/net/netfilter/xt_set.c index 19461c462dbd..0ec8138aa470 100644 --- a/net/netfilter/xt_set.c +++ b/net/netfilter/xt_set.c @@ -13,7 +13,6 @@ #include <linux/module.h> #include <linux/skbuff.h> -#include <linux/version.h> #include <linux/netfilter/x_tables.h> #include <linux/netfilter/xt_set.h> |