diff options
| author | Trond Myklebust <trond.myklebust@primarydata.com> | 2014-05-18 22:05:22 +0400 |
|---|---|---|
| committer | J. Bruce Fields <bfields@redhat.com> | 2014-05-22 23:57:22 +0400 |
| commit | c789102c20bbbdda6831a273e046715be9d6af79 (patch) | |
| tree | df7f2e7d6254ea61c17b48650e38246f2b1ccac0 | |
| parent | 16e4d93f6de7063800f3f5e68f064b0ff8fae9b7 (diff) | |
| download | linux-c789102c20bbbdda6831a273e046715be9d6af79.tar.xz | |
SUNRPC: Fix a module reference leak in svc_handle_xprt
If the accept() call fails, we need to put the module reference.
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
| -rw-r--r-- | net/sunrpc/svc_xprt.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c index 614956f1777e..29772e01b179 100644 --- a/net/sunrpc/svc_xprt.c +++ b/net/sunrpc/svc_xprt.c @@ -730,6 +730,8 @@ static int svc_handle_xprt(struct svc_rqst *rqstp, struct svc_xprt *xprt) newxpt = xprt->xpt_ops->xpo_accept(xprt); if (newxpt) svc_add_new_temp_xprt(serv, newxpt); + else + module_put(xprt->xpt_class->xcl_owner); } else if (xprt->xpt_ops->xpo_has_wspace(xprt)) { /* XPT_DATA|XPT_DEFERRED case: */ dprintk("svc: server %p, pool %u, transport %p, inuse=%d\n", |