summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2020-06-24 04:01:19 +0300
committerJ. Bruce Fields <bfields@redhat.com>2020-06-29 21:48:28 +0300
commitbf2654017e0268cc83dc88d56f0e67ff4406631d (patch)
tree66ca83c8d4156b8dc44b7097e4accfc74fb70520
parent681370f4b00af0fcc65bbfb9f82de526ab7ceb0a (diff)
downloadlinux-bf2654017e0268cc83dc88d56f0e67ff4406631d.tar.xz
nfsd: fix nfsdfs inode reference count leak
I don't understand this code well, but I'm seeing a warning about a still-referenced inode on unmount, and every other similar filesystem does a dput() here. Fixes: e8a79fb14f6b ("nfsd: add nfsd/clients directory") Signed-off-by: J. Bruce Fields <bfields@redhat.com>
-rw-r--r--fs/nfsd/nfsctl.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index cf98a81ca1ea..cd05732f8eaa 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -1335,6 +1335,7 @@ void nfsd_client_rmdir(struct dentry *dentry)
WARN_ON_ONCE(ret);
fsnotify_rmdir(dir, dentry);
d_delete(dentry);
+ dput(dentry);
inode_unlock(dir);
}