diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2013-12-30 02:47:25 +0400 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2014-02-18 20:52:53 +0400 |
| commit | abcdcc29c6aed12c137c8c06ee914d08605bf521 (patch) | |
| tree | f938fb24b7b2f2b03fdbb20407494bfc1cdde63b | |
| parent | 8b3bc14f2d841eaabaaad6aba05b7657dd0b5c7e (diff) | |
| download | linux-abcdcc29c6aed12c137c8c06ee914d08605bf521.tar.xz | |
usb: gadget: fix error return code
Set the return variable to an error code as done elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Felipe Balbi <balbi@ti.com>
| -rw-r--r-- | drivers/usb/gadget/printer.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/usb/gadget/printer.c b/drivers/usb/gadget/printer.c index bf7a56b6d48a..92b55bdda566 100644 --- a/drivers/usb/gadget/printer.c +++ b/drivers/usb/gadget/printer.c @@ -1133,6 +1133,7 @@ static int __init printer_bind_config(struct usb_configuration *c) NULL, "g_printer"); if (IS_ERR(dev->pdev)) { ERROR(dev, "Failed to create device: g_printer\n"); + status = PTR_ERR(dev->pdev); goto fail; } |