diff options
| author | Nathan Chancellor <natechancellor@gmail.com> | 2018-09-21 01:48:30 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-09-22 05:05:57 +0300 |
| commit | 94e7c844990f0db92418586b107be135b4963b66 (patch) | |
| tree | 93b50ede21b90d003d962745432460c8777816aa | |
| parent | 6b8e327cfa2dfb9da2bd70326494a1f5ca9968f7 (diff) | |
| download | linux-94e7c844990f0db92418586b107be135b4963b66.tar.xz | |
net: lan78xx: Avoid unnecessary self assignment
Clang warns when a variable is assigned to itself.
drivers/net/usb/lan78xx.c:940:11: warning: explicitly assigning value of
variable of type 'u32' (aka 'unsigned int') to itself [-Wself-assign]
offset = offset;
~~~~~~ ^ ~~~~~~
1 warning generated.
Reorder the if statement to acheive the same result and avoid a self
assignment warning.
Link: https://github.com/ClangBuiltLinux/linux/issues/129
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/usb/lan78xx.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 04f0a094d864..656441d9a955 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -936,11 +936,9 @@ static int lan78xx_read_otp(struct lan78xx_net *dev, u32 offset, ret = lan78xx_read_raw_otp(dev, 0, 1, &sig); if (ret == 0) { - if (sig == OTP_INDICATOR_1) - offset = offset; - else if (sig == OTP_INDICATOR_2) + if (sig == OTP_INDICATOR_2) offset += 0x100; - else + else if (sig != OTP_INDICATOR_1) ret = -EINVAL; if (!ret) ret = lan78xx_read_raw_otp(dev, offset, length, data); |