diff options
| author | Brandon Wyman <bjwyman@gmail.com> | 2021-08-07 01:51:31 +0300 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2021-08-18 00:54:26 +0300 |
| commit | 76b72736f574ec38b3e94603ea5f74b1853f26b0 (patch) | |
| tree | a7e37cf1b3397923a47b550d72a6f90874a29725 | |
| parent | 2284ed9ffc062d1755a5299e2cc6896d2cfba000 (diff) | |
| download | linux-76b72736f574ec38b3e94603ea5f74b1853f26b0.tar.xz | |
hwmon: (pmbus/ibm-cffps) Fix write bits for LED control
When doing a PMBus write for the LED control on the IBM Common Form
Factor Power Supplies (ibm-cffps), the DAh command requires that bit 7
be low and bit 6 be high in order to indicate that you are truly
attempting to do a write.
Signed-off-by: Brandon Wyman <bjwyman@gmail.com>
Link: https://lore.kernel.org/r/20210806225131.1808759-1-bjwyman@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/pmbus/ibm-cffps.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/hwmon/pmbus/ibm-cffps.c b/drivers/hwmon/pmbus/ibm-cffps.c index 5668d8305b78..df712ce4b164 100644 --- a/drivers/hwmon/pmbus/ibm-cffps.c +++ b/drivers/hwmon/pmbus/ibm-cffps.c @@ -50,9 +50,9 @@ #define CFFPS_MFR_VAUX_FAULT BIT(6) #define CFFPS_MFR_CURRENT_SHARE_WARNING BIT(7) -#define CFFPS_LED_BLINK BIT(0) -#define CFFPS_LED_ON BIT(1) -#define CFFPS_LED_OFF BIT(2) +#define CFFPS_LED_BLINK (BIT(0) | BIT(6)) +#define CFFPS_LED_ON (BIT(1) | BIT(6)) +#define CFFPS_LED_OFF (BIT(2) | BIT(6)) #define CFFPS_BLINK_RATE_MS 250 enum { |