diff options
| author | Vaibhav Gupta <vaibhavgupta40@gmail.com> | 2020-11-02 19:47:19 +0300 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2020-11-26 07:14:51 +0300 |
| commit | 66aea31a2d264cc4a6c0470103b313b7bd1600a5 (patch) | |
| tree | e27cc587269e9697d6596503adae6a031ab326a2 | |
| parent | ef6fa16b5d4a9d3f6ba839737b51d1b2f47259ea (diff) | |
| download | linux-66aea31a2d264cc4a6c0470103b313b7bd1600a5.tar.xz | |
scsi: pm_8001: Drop PCI Wakeup calls from .resume
The driver calls pci_enable_wake(...., false) in pm8001_pci_resume(), and
there is no corresponding pci_enable_wake(...., true) in
pm8001_pci_suspend(). Either it should do enable-wake the device in
.suspend() or should not invoke pci_enable_wake() at all.
Concluding that this driver doesn't support enable-wake and PCI core calls
pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from
pm8001_pci__resume().
Link: https://lore.kernel.org/r/20201102164730.324035-19-vaibhavgupta40@gmail.com
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
| -rw-r--r-- | drivers/scsi/pm8001/pm8001_init.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c index a6b3f1f8c806..9285a9a3557d 100644 --- a/drivers/scsi/pm8001/pm8001_init.c +++ b/drivers/scsi/pm8001/pm8001_init.c @@ -1322,7 +1322,6 @@ static int pm8001_pci_resume(struct pci_dev *pdev) pdev, pm8001_ha->name, device_state); pci_set_power_state(pdev, PCI_D0); - pci_enable_wake(pdev, PCI_D0, 0); pci_restore_state(pdev); rc = pci_enable_device(pdev); if (rc) { |